diff --git a/CHANGELOG.md b/CHANGELOG.md index 955efc3..5494e07 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,13 +4,13 @@ > 7 November 2019 -- chore: add changelog configoration [`#22`](https://github.com/eCollect/node-ebics-client/pull/22) +- chore: add changelog configuration [`#22`](https://github.com/eCollect/node-ebics-client/pull/22) - Closes #17 and #13 [`#21`](https://github.com/eCollect/node-ebics-client/pull/21) - Drop moment dependency [`#20`](https://github.com/eCollect/node-ebics-client/pull/20) - feat: add nyc and cleanup .gitignore [`3e95478`](https://github.com/eCollect/node-ebics-client/commit/3e95478b3be719c86f32c7df10c42e46b7518669) - feat: drop bn.js [`eea0a49`](https://github.com/eCollect/node-ebics-client/commit/eea0a49130e30c123b110120c69d7b7c19fd12ba) -- add changelog configoration [`1f34dcb`](https://github.com/eCollect/node-ebics-client/commit/1f34dcbfb6e0febbb93d5356fa36ac57d697a990) +- add changelog configuration [`1f34dcb`](https://github.com/eCollect/node-ebics-client/commit/1f34dcbfb6e0febbb93d5356fa36ac57d697a990) #### [v0.1.1](https://github.com/eCollect/node-ebics-client/compare/v0.1.0...v0.1.1) @@ -59,7 +59,7 @@ > 2 August 2019 - * Add Z53 order type [`#7`](https://github.com/eCollect/node-ebics-client/pull/7) -- remove eCollect from constant and minor verbose error handeling [`#2`](https://github.com/eCollect/node-ebics-client/pull/2) +- remove eCollect from constant and minor verbose error handling [`#2`](https://github.com/eCollect/node-ebics-client/pull/2) - add iso pain format XCT order type [`#1`](https://github.com/eCollect/node-ebics-client/pull/1) - add new order type XZ53 and removed repeated dateRange to consts [`5ff3147`](https://github.com/eCollect/node-ebics-client/commit/5ff314712443c4c8465f46292b010cfedfed8c2e) @@ -70,10 +70,10 @@ > 24 July 2019 -- remove eCollect from constant and minor verbose error handaling [`#4`](https://github.com/eCollect/node-ebics-client/pull/4) +- remove eCollect from constant and minor verbose error handling [`#4`](https://github.com/eCollect/node-ebics-client/pull/4) - add iso pain format XCT order type [`#5`](https://github.com/eCollect/node-ebics-client/pull/5) -- remove eCollect from constant and minor verbose error handeling [`cb2062a`](https://github.com/eCollect/node-ebics-client/commit/cb2062ae2fbd8e8881de26561efddad1f272e065) +- remove eCollect from constant and minor verbose error handling [`cb2062a`](https://github.com/eCollect/node-ebics-client/commit/cb2062ae2fbd8e8881de26561efddad1f272e065) - bump [`c9f52d3`](https://github.com/eCollect/node-ebics-client/commit/c9f52d3bd99b9f8761652365b217d9580fa34632) #### [v0.0.5](https://github.com/eCollect/node-ebics-client/compare/v0.0.4...v0.0.5) diff --git a/examples/initialize.js b/examples/initialize.js index aade1eb..73e5e59 100755 --- a/examples/initialize.js +++ b/examples/initialize.js @@ -16,11 +16,11 @@ const client = new ebics.Client({ // New keys will be generated and saved in ./keys-test client.send(ebics.Orders.INI) .then((resp) => { - console.log('Respose for INI order %j', resp); + console.log('Response for INI order %j', resp); return client.send(ebics.Orders.HIA); }) .then((resp) => { - console.log('Reponse for HIA order %j', resp); + console.log('Response for HIA order %j', resp); if (resp.technicalCode !== '000000') throw new Error('Something might went wrong'); diff --git a/examples/save-bank-kesy.js b/examples/save-bank-keys.js old mode 100755 new mode 100644 similarity index 93% rename from examples/save-bank-kesy.js rename to examples/save-bank-keys.js index adffa8f..6c99a0d --- a/examples/save-bank-kesy.js +++ b/examples/save-bank-keys.js @@ -17,7 +17,7 @@ const client = new ebics.Client({ // The bank should have enabled the user client.send(ebics.Orders.HPB) .then((resp) => { - console.log('Respose for HPB order %j', resp); + console.log('Response for HPB order %j', resp); if (resp.technicalCode !== '000000') throw new Error('Something went wrong'); diff --git a/examples/send-hbt-order.js b/examples/send-hbt-order.js index 02da48e..742f7d4 100755 --- a/examples/send-hbt-order.js +++ b/examples/send-hbt-order.js @@ -16,7 +16,7 @@ const client = new ebics.Client({ // The bank keys must have been already saved client.send(ebics.Orders.HTD) .then((resp) => { - console.log('Respose for HTD order %j', resp); + console.log('Response for HTD order %j', resp); if (resp.technicalCode !== '000000') throw new Error('Something went wrong'); diff --git a/lib/Client.js b/lib/Client.js index ace9595..fbb7868 100644 --- a/lib/Client.js +++ b/lib/Client.js @@ -37,13 +37,13 @@ const stringifyKeys = (keys) => { */ /** - * Client initilization options + * Client initialization options * @typedef {Object} EbicClientOptions * @property {string} url - EBICS URL provided by the bank * @property {string} partnerId - PARTNERID provided by the bank * @property {string} hostId - HOSTID provided by the bank * @property {string} userId - USERID provided by the bank - * @property {string} passphrase - passphrase for keys encyprion + * @property {string} passphrase - passphrase for keys encryption * @property {KeyStorage} keyStorage - keyStorage implementation * @property {object} [tracesStorage] - traces (logs) storage implementation */ @@ -64,15 +64,15 @@ module.exports = class Client { tracesStorage, }) { if (!url) - throw new Error('EBICS URL is requierd'); + throw new Error('EBICS URL is required'); if (!partnerId) - throw new Error('partnerId is requierd'); + throw new Error('partnerId is required'); if (!userId) - throw new Error('userId is requierd'); + throw new Error('userId is required'); if (!hostId) - throw new Error('hostId is requierd'); + throw new Error('hostId is required'); if (!passphrase) - throw new Error('passphrase is requierd'); + throw new Error('passphrase is required'); if (!keyStorage || typeof keyStorage.read !== 'function' || typeof keyStorage.write !== 'function') throw new Error('keyStorage implementation missing or wrong'); diff --git a/lib/orders/H004/errors.js b/lib/orders/H004/errors.js index cf4e608..e9de179 100644 --- a/lib/orders/H004/errors.js +++ b/lib/orders/H004/errors.js @@ -10,12 +10,12 @@ const errors = { '011000': { symbol: 'EBICS_DOWNLOAD_POSTPROCESS_DONE', short_text: 'Positive acknowledgement received', - meaning: "After receipt of a positive acknowledgement the download task was finished at the server's end and the EBICS transaction ended.", + meaning: "After receipt of a positive acknowledgment the download task was finished at the server's end and the EBICS transaction ended.", }, '011001': { symbol: 'EBICS_DOWNLOAD_POSTPROCESS_SKIPPED', - short_text: 'Negative acknowledgement received', - meaning: "After receipt of a negative acknowledgement the transaction was ended at the server's end without finishing the download task", + short_text: 'Negative acknowledgment received', + meaning: "After receipt of a negative acknowledgment the transaction was ended at the server's end without finishing the download task", }, '011101': { symbol: 'EBICS_TX_SEGMENT_NUMBER_UNDERRUN', @@ -104,8 +104,8 @@ const errors = { }, '091102': { symbol: 'EBICS_TX_ABORT', - short_text: 'Transaction cancelled', - meaning: "The transaction was cancelled at the server's end since recovery of the transaction is not supported or is no longer possible due to the recovery counter being too high", + short_text: 'Transaction canceled', + meaning: "The transaction was canceled at the server's end since recovery of the transaction is not supported or is no longer possible due to the recovery counter being too high", }, '091103': { symbol: 'EBICS_TX_MESSAGE_REPLAY',