client and order optimization

lib/orders/H004/serializers/generic.js

@@ -1,5 +1,7 @@
 'use strict';
 
+const constants = require('../../../consts');
+
 const rootName = 'ebicsRequest';
 const rootAttributes = {
 	'xmlns:ds': 'http://www.w3.org/2000/09/xmldsig#',
@@ -58,76 +60,75 @@ const xmlOptions = {
 	},
 };
 
-module.exports = (orderBuilder) => {
-	const { ebicsData, transactionId } = orderBuilder;
+module.exports = (hostId, transactionId) => ({
+	// return {
+	productString: constants.productString,
+	rootName,
+	xmlOptions,
+	xmlSchema: {
+		'@': rootAttributes,
+		header,
+		AuthSignature: authSignature,
+		body,
+	},
 
-	return {
-		rootName,
-		xmlOptions,
-		xmlSchema: {
+	receipt() {
+		this.xmlSchema = {
 			'@': rootAttributes,
-			header,
+
+			header: {
+				'@': { authenticate: true },
+				static: {
+					HostID: hostId,
+					TransactionID: transactionId,
+				},
+				mutable: {
+					TransactionPhase: 'Receipt',
+				},
+			},
+
 			AuthSignature: authSignature,
-			body,
-		},
 
-		receipt() {
-			this.xmlSchema = {
-				'@': rootAttributes,
-
-				header: {
+			body: {
+				TransferReceipt: {
 					'@': { authenticate: true },
-					static: {
-						HostID: ebicsData.hostId,
-						TransactionID: transactionId,
-					},
-					mutable: {
-						TransactionPhase: 'Receipt',
+					ReceiptCode: 0,
+				},
+			},
+		};
+
+		return this;
+	},
+
+	transfer(encryptedOrderData) {
+		this.xmlSchema = {
+			'@': rootAttributes,
+
+			header: {
+				'@': { authenticate: true },
+				static: {
+					HostID: hostId,
+					TransactionID: transactionId,
+				},
+				mutable: {
+					TransactionPhase: 'Transfer',
+					SegmentNumber: {
+						'@': { lastSegment: true },
+						'#': 1,
 					},
 				},
+			},
 
-				AuthSignature: authSignature,
+			AuthSignature: authSignature,
 
-				body: {
-					TransferReceipt: {
-						'@': { authenticate: true },
-						ReceiptCode: 0,
-					},
+			body: {
+				DataTransfer: {
+					OrderData: encryptedOrderData,
 				},
-			};
+			},
+		};
 
-			return this;
-		},
-
-		transfer(encryptedOrderData) {
-			this.xmlSchema = {
-				'@': rootAttributes,
-
-				header: {
-					'@': { authenticate: true },
-					static: {
-						HostID: ebicsData.hostId,
-						TransactionID: transactionId,
-					},
-					mutable: {
-						TransactionPhase: 'Transfer',
-						SegmentNumber: {
-							'@': { lastSegment: true },
-							'#': 1,
-						},
-					},
-				},
-
-				AuthSignature: authSignature,
-
-				body: {
-					DataTransfer: {
-						OrderData: encryptedOrderData,
-					},
-				},
-			};
-
-			return this;
-		},
-	};
-};
+		return this;
+	},
+	// };
+});