[FIX] ebics download: execute always client.confirm_download()

Certain banks expect always a confirm_download, also in case of success=False.

account_ebics/wizards/ebics_xfer.py

@@ -237,8 +237,8 @@ class EbicsXfer(models.TransientModel):
             date_from = self.date_from and self.date_from.isoformat() or None
             date_to = self.date_to and self.date_to.isoformat() or None
             for df in download_formats:
-                try:
                 success = False
+                try:
                     if df.order_type == "BTD":
                         btf = BusinessTransactionFormat(
                             df.btf_service,
@@ -321,8 +321,8 @@ class EbicsXfer(models.TransientModel):
                         order_type=df.order_type,
                     )
                     tb = "".join(format_exception(*exc_info()))
-                    self.note += "\n%s" % tb
-                else:
+                    self.note += f"\n{tb}"
+                finally:
                     # mark received data so that it is not included in further
                     # downloads
                     trans_id = client.last_trans_id