Mirror/odoo_account_ebics
4
0 Fork 0
mirror of https://github.com/brain-tec/account_ebics.git synced 2026-11-06 10:00:39 +00:00
Code Issues Projects Releases Wiki Activity

[FIX] account_ebics - Number duplicate upload file names before the extension

Browse Source 
A duplicate upload name got the counter appended to the previous
candidate and after the extension: pay.xml_1, then pay.xml_1_2,
pay.xml_1_2_3. Keep the extension and number from the original name:
pay_1.xml, pay_2.xml.
This commit is contained in:
Jérémy Didderen committed 2026-10-27 23:14:49 +01:00
1 parent a1fc381121
commit 0c86f79669
2 files changed
+15 -6
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

account_ebics/tests/test_ebics_xfer.py
+10 -4
View File
@@ -190,14 +190,20 @@ class TestEbicsXferUpload(EbicsTestCommon):
self.assertFalse(self.ebics_config.order_number)
def test_upload_same_name_twice(self):
"""The counter goes before the extension and does not stack up."""
names = []
for _i in range(3):
for _i in range(4):
wizard = self._upload_wizard(self.ff_btu)
with self._fake_client(FakeEbicsClient()):
names.append(wizard._ebics_upload().name)
# Pinned, probably unintended: _update_ef_vals appends each counter to
# the previous candidate (pay.xml_1_2) instead of pay.xml_2.
self.assertEqual(names, ["pay.xml", "pay.xml_1", "pay.xml_1_2"])
self.assertEqual(names, ["pay.xml", "pay_1.xml", "pay_2.xml", "pay_3.xml"])
# without extension
wizard = self._upload_wizard(self.ff_btu, fname="pay")
with self._fake_client(FakeEbicsClient()):
self.assertEqual(wizard._ebics_upload().name, "pay")
wizard = self._upload_wizard(self.ff_btu, fname="pay")
with self._fake_client(FakeEbicsClient()):
self.assertEqual(wizard._ebics_upload().name, "pay_1")
def test_upload_ful_h003_order_number(self):
self.ebics_config.write({"ebics_version": "H003", "order_number": "A00Z"})