From 1638aae5ca2b41ca0eac7470ca487a3defc0c445 Mon Sep 17 00:00:00 2001
From: Luc De Meyer <luc.demeyer@noviat.com>
Date: Sun, 25 Jun 2023 17:04:49 +0200
Subject: [PATCH] rename ui_designation to transaction_rights

---
 account_ebics/models/ebics_userid.py       | 9 +++++----
 account_ebics/views/ebics_userid_views.xml | 2 +-
 account_ebics/wizards/ebics_xfer.py        | 4 ++--
 account_ebics/wizards/ebics_xfer.xml       | 4 ++--
 4 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/account_ebics/models/ebics_userid.py b/account_ebics/models/ebics_userid.py
index f60b04c..2e1cfb3 100644
--- a/account_ebics/models/ebics_userid.py
+++ b/account_ebics/models/ebics_userid.py
@@ -84,16 +84,17 @@ class EbicsUserID(models.Model):
         "This default can be overriden for specific "
         "EBICS transactions (cf. File Formats).",
     )
-    ui_designation = fields.Selection(
-        [
+    transaction_rights = fields.Selection(
+        selection=[
             ("both", "Download and Upload"),
             ("down", "Download Only"),
             ("up", "Upload Only"),
         ],
-        string="UI Designation",
+        string="Allowed Transactions",
         default="both",
         required=True,
-        help="Defines in what form this User will be available for selection.",
+        help="Use this parameter to limit the transactions for this User "
+        "to downloads or uploads.",
     )
     ebics_keys_fn = fields.Char(compute="_compute_ebics_keys_fn")
     ebics_keys_found = fields.Boolean(compute="_compute_ebics_keys_found")
diff --git a/account_ebics/views/ebics_userid_views.xml b/account_ebics/views/ebics_userid_views.xml
index 22f46b6..afe3088 100644
--- a/account_ebics/views/ebics_userid_views.xml
+++ b/account_ebics/views/ebics_userid_views.xml
@@ -94,8 +94,8 @@
                             attrs="{'required': [('ebics_passphrase_store', '=', True)], 'invisible': [('state', '!=', 'draft')]}"
                         />
             <field name="ebics_passphrase_store" />
+            <field name="transaction_rights" />
             <field name="active" />
-            <field name="ui_designation" />
           </group>
           <group name="main-right">
             <field name="signature_class" />
diff --git a/account_ebics/wizards/ebics_xfer.py b/account_ebics/wizards/ebics_xfer.py
index 4d68825..44a5504 100644
--- a/account_ebics/wizards/ebics_xfer.py
+++ b/account_ebics/wizards/ebics_xfer.py
@@ -122,14 +122,14 @@ class EbicsXfer(models.TransientModel):
                 lambda r: r.type == "down"
             )
             avail_userids = avail_userids.filtered(
-                lambda r: r.ui_designation in ["both", 'down']
+                lambda r: r.transaction_rights in ["both", "down"]
             )
         else:  # Upload Form
             avail_formats = self.ebics_config_id.ebics_file_format_ids.filtered(
                 lambda r: r.type == "up"
             )
             avail_userids = avail_userids.filtered(
-                lambda r: r.ui_designation in ["both", "up"]
+                lambda r: r.transaction_rights in ["both", "up"]
             )
 
         if avail_formats and len(avail_formats) == 1:
diff --git a/account_ebics/wizards/ebics_xfer.xml b/account_ebics/wizards/ebics_xfer.xml
index 3f691de..9cb67fb 100644
--- a/account_ebics/wizards/ebics_xfer.xml
+++ b/account_ebics/wizards/ebics_xfer.xml
@@ -16,7 +16,7 @@
                     />
           <field
                         name="ebics_userid_id"
-                        domain="[('ebics_config_id', '=', ebics_config_id), ('user_ids.id', '=', uid), ('ui_designation', 'in', ['both', 'down'])]"
+                        domain="[('ebics_config_id', '=', ebics_config_id), ('user_ids.id', '=', uid), ('transaction_rights', 'in', ['both', 'down'])]"
                         required="1"
                         options="{'no_create': True, 'no_open': True}"
                     />
@@ -69,7 +69,7 @@
                     />
           <field
                         name="ebics_userid_id"
-                        domain="[('ebics_config_id', '=', ebics_config_id), ('user_ids.id', '=', uid), ('ui_designation', 'in', ['both', 'up'])]"
+                        domain="[('ebics_config_id', '=', ebics_config_id), ('user_ids.id', '=', uid), ('transaction_rights', 'in', ['both', 'up'])]"
                         required="1"
                         options="{'no_create': True, 'no_open': True}"
                     />