[18.0][IMP] pre-commit updates

account_ebics/models/account_journal.py

@@ -11,13 +11,13 @@ class AccountJournal(models.Model):
         comodel_name="ebics.config",
         relation="account_journal_ebics_config_rel",
         readonly=True,
-        string="Ebics Configs",
+        string="EBICS Configs",
     )
     ebics_config_id = fields.Many2one(
         comodel_name="ebics.config",
         compute="_compute_ebics_config_id",
         compute_sudo=True,
-        string="Ebics Config",
+        string="EBICS Config",
     )
 
     @api.depends("ebics_config_ids")

account_ebics/models/ebics_config.py

@@ -8,7 +8,7 @@ import re
 from odoo import api, fields, models
 from odoo.exceptions import UserError
 
-_logger = logging.getLogger(__name__)
+_logger = logging.getLogger(__name__)  # lint-ignore=unused-logger
 
 
 class EbicsConfig(models.Model):
@@ -160,13 +160,12 @@ class EbicsConfig(models.Model):
         for rec in self:
             rec.company_ids = rec.journal_ids.mapped("company_id")
 
-    def unlink(self):
-        for ebics_config in self:
-            if ebics_config.state == "active":
-                raise UserError(
-                    self.env._("You cannot remove active EBICS configurations.")
-                )
-        return super().unlink()
+    @api.ondelete(at_uninstall=False)
+    def _unlink_except_active(self):
+        if any(rec.state == "active" for rec in self):
+            raise UserError(
+                self.env._("You cannot remove active EBICS configurations.")
+            )
 
     def set_to_draft(self):
         return self.write({"state": "draft"})
@@ -199,8 +198,8 @@ class EbicsConfig(models.Model):
         if not os.path.exists(dirname):
             raise UserError(
                 self.env._(
-                    "EBICS Keys Root Directory %s is not available."
-                    "\nPlease contact your system administrator."
+                    "EBICS Keys Root Directory %(dir)s is not available."
+                    "\nPlease contact your system administrator.",
+                    dir=dirname,
                 )
-                % dirname
             )

account_ebics/models/ebics_file.py

@@ -9,12 +9,12 @@ from traceback import format_exception
 
 from lxml import etree
 
-from odoo import fields, models
+from odoo import api, fields, models
 from odoo.exceptions import UserError
 
 from odoo.addons.base.models.res_bank import sanitize_account_number
 
-_logger = logging.getLogger(__name__)
+_logger = logging.getLogger(__name__)  # lint-ignore=unused-logger
 
 DUP_CHECK_FORMATS = ["cfonb120", "camt053"]
 
@@ -63,7 +63,6 @@ class EbicsFile(models.Model):
     )
     user_id = fields.Many2one(
         comodel_name="res.users",
-        string="User",
         default=lambda self: self.env.user,
         readonly=True,
     )
@@ -91,13 +90,16 @@ class EbicsFile(models.Model):
         help="Companies sharing this EBICS file.",
     )
 
+    @api.ondelete(at_uninstall=False)
+    def _unlink_except_done(self):
+        if any(rec.state == "done" for rec in self):
+            raise UserError(
+                self.env._("You can only remove EBICS files in state 'Draft'.")
+            )
+
     def unlink(self):
         ff_methods = self._file_format_methods()
         for ebics_file in self:
-            if ebics_file.state == "done":
-                raise UserError(
-                    self.env._("You can only remove EBICS files in state 'Draft'.")
-                )
             # execute format specific actions
             ff = ebics_file.format_id.download_process_method
             if ff in ff_methods:
@@ -385,8 +387,7 @@ class EbicsFile(models.Model):
         file_data = base64.b64decode(self.data).replace(b"\n", b"").replace(b"\r", b"")
         if len(file_data) % 120:
             message = self.env._(
-                "Incorrect CFONB120 file:\n"
-                "the file is not divisible in 120 char lines"
+                "Incorrect CFONB120 file:\nthe file is not divisible in 120 char lines"
             )
             res["notifications"].append({"type": "error", "message": message})
             return datas
@@ -650,7 +651,7 @@ class EbicsFile(models.Model):
             self.env._(
                 "The current version of the 'account_ebics' module "
                 "has no support to automatically process EBICS files "
-                "with format %s."
+                "with format %s.",
+                self.format_id.name,
             )
-            % self.format_id.name
         )

account_ebics/models/ebics_userid.py

@@ -69,8 +69,7 @@ class EbicsUserID(models.Model):
         string="Users",
         required=True,
         domain=[("share", "=", False)],
-        help="Users who are allowed to use this EBICS UserID for "
-        " bank transactions.",
+        help="Users who are allowed to use this EBICS UserID for bank transactions.",
     )
     signature_class = fields.Selection(
         selection=[("E", "Single signature"), ("T", "Transport signature")],
@@ -149,7 +148,7 @@ class EbicsUserID(models.Model):
     # create self-signed X.509 certificates
     ebics_key_x509 = fields.Boolean(
         string="X509 support",
-        help="Set this flag in order to work with " "self-signed X.509 certificates",
+        help="Set this flag in order to work with self-signed X.509 certificates",
     )
     ebics_key_x509_dn_cn = fields.Char(
         string="Common Name [CN]",
@@ -417,7 +416,7 @@ class EbicsUserID(models.Model):
         if not ebics_config_bank:
             raise UserError(
                 self.env._(
-                    "No bank defined for the financial journal " "of the EBICS Config"
+                    "No bank defined for the financial journal of the EBICS Config"
                 )
             )
         try:
@@ -476,8 +475,7 @@ class EbicsUserID(models.Model):
         if cc in ["FR", "DE"]:
             lang = cc
         else:
-            lang = self.env.user.lang or self.env["res.lang"].search([])[0].code
-            lang = lang[:2]
+            lang = self.env.user.lang[:2]
         lang = lang.lower()
         lang = lang if lang in INI_LETTER_LANGS else "en"
         fn_date = fields.Date.today().isoformat()