[IMP] addons-repo-template v9.2.1

account_ebics/models/ebics_userid.py

@@ -38,7 +38,7 @@ class EbicsBank(EbicsBank):
         The OrderID must be a string between 'A000' and 'ZZZZ' and
         unique for each partner id.
         """
-        return hasattr(self, "_order_number") and self._order_number or "A000"
+        return (hasattr(self, "_order_number") and self._order_number) or "A000"
 
 
 class EbicsUserID(models.Model):
@@ -216,7 +216,9 @@ class EbicsUserID(models.Model):
             rec.ebics_passphrase_store_readonly = True
             if rec.state == "draft":
                 rec.ebics_passphrase_required = True
-                rec.ebics_passphrase_invisible = rec.ebics_keys_found and True or False
+                rec.ebics_passphrase_invisible = (
+                    rec.ebics_keys_found and True
+                ) or False
                 rec.ebics_passphrase_store_readonly = False
             elif rec.state == "init":
                 rec.ebics_passphrase_required = False
@@ -289,9 +291,8 @@ class EbicsUserID(models.Model):
                     keyring["#USER"]
                 except ValueError as err:  # noqa: F841
                     raise UserError(self.env._("Passphrase mismatch."))  # noqa: B904
-        else:
-            if self.state != "draft":
-                self.ebics_passphrase = False
+        elif self.state != "draft":
+            self.ebics_passphrase = False
 
     @api.onchange("swift_3skey")
     def _onchange_swift_3skey(self):
@@ -479,7 +480,7 @@ class EbicsUserID(models.Model):
         lang = lang.lower()
         lang = lang if lang in INI_LETTER_LANGS else "en"
         fn_date = fields.Date.today().isoformat()
-        fn = "_".join([self.ebics_config_id.ebics_host, "ini_letter", fn_date]) + ".pdf"
+        fn = f"{self.ebics_config_id.ebics_host}_ini_letter_{fn_date}" + ".pdf"
         letter = user.create_ini_letter(bankname=ebics_config_bank.name, lang=lang)
         vals = {
             "ebics_ini_letter": base64.encodebytes(letter),
@@ -548,10 +549,7 @@ class EbicsUserID(models.Model):
 
         public_bank_keys = public_bank_keys.encode()
         fn_date = fields.Date.today().isoformat()
-        fn = (
-            "_".join([self.ebics_config_id.ebics_host, "public_bank_keys", fn_date])
-            + ".txt"
-        )
+        fn = f"{self.ebics_config_id.ebics_host}_public_bank_keys_{fn_date}" + ".txt"
         vals = {
             "ebics_public_bank_keys": base64.encodebytes(public_bank_keys),
             "ebics_public_bank_keys_fn": fn,