Merge pull request #5 from Noviat/14.0

Syncing from upstream Noviat/account_ebics (14.0)

.copier-answers.yml

@@ -1,13 +1,14 @@
 # Do NOT update manually; changes here will be overwritten by Copier
-_commit: v1.1.1
+_commit: v1.2
-_src_path: gh:oca/oca-addons-repo-template
+_src_path: https://picasso.noviat.com/ci/addons-repo-template.git
-dependency_installation_mode: PIP
+ci_exclude_modules: account_asset
-generate_requirements_txt: true
+ci_image: ghcr.io/oca/oca-ci/py3.6-odoo14.0:latest
-include_wkhtmltopdf: false
+customer_slug: Noviat_Generic
+odoo_enterprise: 1
 odoo_version: 14.0
-rebel_module_groups: []
+org_name: Noviat
-repo_description: "TODO: add repo description."
+org_slug: Noviat
-repo_name: web
+repo_name: Modules dedicated to manage the EBICS protocol
-repo_slug: web
+repo_slug: accounting-ebics
-travis_apt_packages: []
+repo_website: https://www.noviat.com/
-travis_apt_sources: []
+

.eslintrc.yml

@@ -1,9 +1,16 @@
 env:
   browser: true
+  es6: true
 
 # See https://github.com/OCA/odoo-community.org/issues/37#issuecomment-470686449
 parserOptions:
-  ecmaVersion: 2017
+  ecmaVersion: 2019
+
+overrides:
+  - files:
+      - "**/*.esm.js"
+    parserOptions:
+      sourceType: module
 
 # Globals available in Odoo that shouldn't produce errorings
 globals:
@@ -14,7 +21,7 @@ globals:
   moment: readonly
   odoo: readonly
   openerp: readonly
-  Promise: readonly
+  owl: readonly
 
 # Styling is handled by Prettier, so we only need to enable AST rules;
 # see https://github.com/OCA/maintainer-quality-tools/pull/618#issuecomment-558576890

.flake8

@@ -1,5 +1,5 @@
 [flake8]
-max-line-length = 80
+max-line-length = 88
 max-complexity = 16
 # B = bugbear
 # B9 = bugbear opinionated (incl line length)
@@ -8,3 +8,5 @@ select = C,E,F,W,B,B9
 # E501: flake8 line length (covered by bugbear B950)
 # W503: line break before binary operator (black behaviour)
 ignore = E203,E501,W503
+per-file-ignores=
+    __init__.py:F401

.gitignore

@@ -1,6 +1,8 @@
 # Byte-compiled / optimized / DLL files
 __pycache__/
 *.py[cod]
+/.venv
+/.pytest_cache
 
 # C extensions
 *.so
@@ -40,6 +42,19 @@ coverage.xml
 # Pycharm
 .idea
 
+# Eclipse
+.settings
+
+# Visual Studio cache/options directory
+.vs/
+.vscode
+
+# OSX Files
+.DS_Store
+
+# Django stuff:
+*.log
+
 # Mr Developer
 .mr.developer.cfg
 .project

.gitlab-ci.yml

@@ -0,0 +1,14 @@
+include:
+  - project: "ci/gitlabci-odoo"
+    ref: main
+    file: "/odoo-tests.template.yml"
+
+variables:
+  ODOO_CI_IMAGE: ghcr.io/oca/oca-ci/py3.6-odoo14.0:latest
+  PRECOMMIT_IMAGE: python:3.6
+  VERSION: "14.0"
+  ODOO_BRANCH: "14.0"
+  ENTERPRISE: "1"
+  ODOO_PRECOMMIT: "1"
+  ODOO_TEST: "1"
+  EXCLUDE_MODULES: "account_asset"

.isort.cfg

@@ -10,3 +10,4 @@ known_odoo=odoo
 known_odoo_addons=odoo.addons
 sections=FUTURE,STDLIB,THIRDPARTY,ODOO,ODOO_ADDONS,FIRSTPARTY,LOCALFOLDER
 default_section=THIRDPARTY
+ensure_newline_before_comments = True

.pre-commit-config.yaml

@@ -5,7 +5,7 @@ exclude: |
   # Files and folders generated by bots, to avoid loops
   ^setup/|/static/description/index\.html$|
   # We don't want to mess with tool-generated files
-  .svg$|
+  .svg$|/tests/([^/]+/)?cassettes/|^.copier-answers.yml$|^.github/|
   # Maybe reactivate this when all README files include prettier ignore tags?
   ^README\.md$|
   # Library files can have extraneous formatting (even minimized)
@@ -14,9 +14,11 @@ exclude: |
   ^docs/_templates/.*\.html$|
   # You don't usually want a bot to modify your legal texts
   (LICENSE.*|COPYING.*)
+  # Exclude the TODO folders
+  /TODO/
 default_language_version:
   python: python3
-  node: "14.13.0"
+  node: "16.10.0"
 repos:
   - repo: local
     hooks:
@@ -27,32 +29,44 @@ repos:
         entry: found forbidden files; remove them
         language: fail
         files: "\\.rej$"
+      - id: en-po-files
+        name: en.po files cannot exist
+        entry: found a en.po file
+        language: fail
+        files: '[a-zA-Z0-9_]*/i18n/en\.po$'
   - repo: https://github.com/oca/maintainer-tools
     rev: ab1d7f6
     hooks:
       # update the NOT INSTALLABLE ADDONS section above
       - id: oca-update-pre-commit-excluded-addons
-      # - id: oca-fix-manifest-website
+      - id: oca-fix-manifest-website
-      #  args: ["https://github.com/OCA/web"]
+        args: ["https://www.noviat.com/"]
   - repo: https://github.com/myint/autoflake
     rev: v1.4
     hooks:
       - id: autoflake
-        args: ["-i", "--ignore-init-module-imports"]
+        args:
+          - --expand-star-imports
+          - --ignore-init-module-imports
+          - --in-place
+          - --remove-all-unused-imports
+          - --remove-duplicate-keys
+          - --remove-unused-variables
   - repo: https://github.com/psf/black
-    rev: 20.8b1
+    rev: 22.3.0
     hooks:
       - id: black
   - repo: https://github.com/pre-commit/mirrors-prettier
     rev: v2.1.2
     hooks:
       - id: prettier
-        name: prettier + plugin-xml
+        name: prettier (with plugin-xml)
         additional_dependencies:
           - "prettier@2.1.2"
           - "@prettier/plugin-xml@0.12.0"
         args:
           - --plugin=@prettier/plugin-xml
+        files: \.(css|htm|html|js|json|jsx|less|md|scss|toml|ts|xml|yaml|yml)$
   - repo: https://github.com/pre-commit/mirrors-eslint
     rev: v7.8.1
     hooks:
@@ -87,6 +101,7 @@ repos:
     rev: v2.7.2
     hooks:
       - id: pyupgrade
+        args: ["--keep-percent-format"]
   - repo: https://github.com/PyCQA/isort
     rev: 5.5.1
     hooks:
@@ -96,7 +111,7 @@ repos:
           - --settings=.
         exclude: /__init__\.py$
   - repo: https://github.com/acsone/setuptools-odoo
-    rev: 2.6.0
+    rev: 3.1.8
     hooks:
       - id: setuptools-odoo-make-default
       - id: setuptools-odoo-get-requirements
@@ -109,27 +124,17 @@ repos:
     rev: 3.8.3
     hooks:
       - id: flake8
-        name: flake8 except __init__.py
+        name: flake8
-        exclude: /__init__\.py$
         additional_dependencies: ["flake8-bugbear==20.1.4"]
-      - id: flake8
+  - repo: https://github.com/OCA/pylint-odoo
-        name: flake8 only __init__.py
+    rev: 7.0.2
-        args: ["--extend-ignore=F401"] # ignore unused imports in __init__.py
-        files: /__init__\.py$
-        additional_dependencies: ["flake8-bugbear==20.1.4"]
-  - repo: https://github.com/PyCQA/pylint
-    rev: pylint-2.5.3
     hooks:
-      - id: pylint
+      - id: pylint_odoo
         name: pylint with optional checks
         args:
           - --rcfile=.pylintrc
           - --exit-zero
         verbose: true
-        additional_dependencies: &pylint_deps
+      - id: pylint_odoo
-          - pylint-odoo==3.5.0
-      - id: pylint
-        name: pylint with mandatory checks
         args:
           - --rcfile=.pylintrc-mandatory
-        additional_dependencies: *pylint_deps

.pylintrc

@@ -1,4 +1,6 @@
+
 [MASTER]
+ignore-patterns=["^.*/TODO/.*$"]
 load-plugins=pylint_odoo
 score=n
 
@@ -73,7 +75,7 @@ enable=anomalous-backslash-in-string,
     invalid-commit,
     missing-manifest-dependency,
     missing-newline-extrafiles,
-    # missing-readme,
+    missing-readme,
     no-utf8-coding-comment,
     odoo-addons-relative-import,
     old-api7-method-defined,

.pylintrc-mandatory

@@ -1,9 +1,10 @@
 [MASTER]
+ignore-patterns=["^.*/TODO/.*$"]
 load-plugins=pylint_odoo
 score=n
 
 [ODOOLINT]
-readme_template_url="https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst"
+# readme_template_url="https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst"
 manifest_required_authors=Noviat
 manifest_required_keys=license
 manifest_deprecated_keys=description,active

README.md

@@ -1,5 +1,20 @@
-![Licence](https://img.shields.io/badge/licence-AGPL--3-blue.svg)
+[![pipeline status](https://picasso.noviat.com/Noviat/Noviat_Generic/accounting-ebics/badges/14.0/pipeline.svg)](https://picasso.noviat.com/Noviat/Noviat_Generic/accounting-ebics/-/commits/14.0)
+[![coverage report](https://picasso.noviat.com/Noviat/Noviat_Generic/accounting-ebics/badges/14.0/coverage.svg)](https://picasso.noviat.com/Noviat/Noviat_Generic/accounting-ebics/-/commits/14.0)
 
-EBICS support for Odoo
+<!-- /!\ do not modify above this line -->
-======================
 
+# Modules dedicated to manage the EBICS protocol
+
+<!-- /!\ do not modify below this line -->
+
+<!-- prettier-ignore-start -->
+
+[//]: # (addons)
+
+This part will be replaced when running the oca-gen-addons-table script from OCA/maintainer-tools.
+
+[//]: # (end addons)
+
+<!-- prettier-ignore-end -->
+
+----

account_ebics/__manifest__.py

@@ -6,7 +6,7 @@
     "version": "14.0.1.1.3",
     "license": "LGPL-3",
     "author": "Noviat",
-    "website": "https://www.noviat.com",
+    "website": "https://www.noviat.com/",
     "category": "Accounting & Finance",
     "depends": ["account"],
     "data": [

account_ebics_batch/__manifest__.py

@@ -6,7 +6,7 @@
     "version": "14.0.1.0.0",
     "license": "AGPL-3",
     "author": "Noviat",
-    "website": "http://www.noviat.com",
+    "website": "https://www.noviat.com/",
     "category": "Accounting & Finance",
     "summary": "EBICS Files automated import and processing",
     "depends": ["account_ebics"],

account_ebics_batch_payment/__manifest__.py

@@ -6,6 +6,7 @@
     "version": "14.0.1.1.0",
     "license": "LGPL-3",
     "author": "Noviat",
+    "website": "https://www.noviat.com/",
     "category": "Accounting & Finance",
     "depends": ["account_ebics", "account_batch_payment"],
     "data": ["views/account_batch_payment_views.xml"],

account_ebics_oca_statement_import/__manifest__.py

@@ -6,6 +6,7 @@
     "summary": "Use OCA Bank Statement Import with account_ebics",
     "version": "14.0.1.0.1",
     "author": "Noviat",
+    "website": "https://www.noviat.com/",
     "category": "Hidden",
     "license": "LGPL-3",
     "depends": [

account_ebics_oca_statement_import/wizards/account_statement_import.py

@@ -12,7 +12,7 @@ class AccountStatementImport(models.TransientModel):
     _inherit = "account.statement.import"
 
     def _check_parsed_data(self, stmts_vals):
-        """ Basic and structural verifications """
+        """Basic and structural verifications"""
         if self.env.context.get("active_model") == "ebics.file":
             message = False
             if len(stmts_vals) == 0:

account_ebics_oe/__manifest__.py

@@ -6,6 +6,7 @@
     "summary": "Deploy account_ebics module on Odoo Enterprise",
     "version": "14.0.1.0.0",
     "author": "Noviat",
+    "website": "https://www.noviat.com/",
     "category": "Hidden",
     "license": "LGPL-3",
     "depends": [

account_ebics_oe_statement_import/__manifest__.py

@@ -6,6 +6,7 @@
     "summary": "Use Odoo Enterprise Bank Statement Import with account_ebics",
     "version": "14.0.1.0.0",
     "author": "Noviat",
+    "website": "https://www.noviat.com/",
     "category": "Hidden",
     "license": "LGPL-3",
     "depends": [

account_ebics_oe_statement_import/wizards/account_bank_statement_import.py

@@ -12,7 +12,7 @@ class AccountBankStatementImport(models.TransientModel):
     _inherit = "account.bank.statement.import"
 
     def _check_parsed_data(self, stmts_vals, account_number):
-        """ Basic and structural verifications """
+        """Basic and structural verifications"""
         if self.env.context.get("active_model") == "ebics.file":
             message = False
             if len(stmts_vals) == 0:

account_ebics_payment_order/__manifest__.py

@@ -6,6 +6,7 @@
     "version": "14.0.1.0.0",
     "license": "LGPL-3",
     "author": "Noviat",
+    "website": "https://www.noviat.com/",
     "category": "Accounting & Finance",
     "depends": ["account_ebics", "account_payment_order"],
     "data": [