From b8f8e64200266ade1aecea212c45b827bd18d5c4 Mon Sep 17 00:00:00 2001 From: Luc De Meyer Date: Sat, 2 Dec 2023 18:35:04 +0100 Subject: [PATCH 1/2] [IMP]add support for signature passphrase --- account_ebics/wizards/ebics_xfer.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/account_ebics/wizards/ebics_xfer.py b/account_ebics/wizards/ebics_xfer.py index b2ee29e..1aa89f7 100644 --- a/account_ebics/wizards/ebics_xfer.py +++ b/account_ebics/wizards/ebics_xfer.py @@ -463,7 +463,7 @@ class EbicsXfer(models.TransientModel): "passphrase": passphrase, } if self.ebics_sig_passphrase: - keyring_params["sig_passphrase"] = self.ebics_sig_passphrase + keyring_params["sig_passphrase"] = self.ebics_sig_passphrase try: keyring = EbicsKeyRing(**keyring_params) except (RuntimeError, ValueError) as err: From bee5cf142f6220b9ce914a547a4782b6eade3050 Mon Sep 17 00:00:00 2001 From: Luc De Meyer Date: Sun, 3 Dec 2023 11:17:18 +0100 Subject: [PATCH 2/2] [IMP] account_ebics : update doc for EDS --- account_ebics/README.rst | 11 ++++++++++- account_ebics/models/ebics_userid.py | 2 +- account_ebics/static/description/index.html | 9 ++++++++- account_ebics/wizards/ebics_xfer.py | 2 +- 4 files changed, 20 insertions(+), 4 deletions(-) diff --git a/account_ebics/README.rst b/account_ebics/README.rst index f054250..9f939ab 100644 --- a/account_ebics/README.rst +++ b/account_ebics/README.rst @@ -187,9 +187,18 @@ You can also find this information in the doc folder of this module (file EBICS_ | +Electronic Distributed Signature (EDS) +-------------------------------------- + +This is supported via external signing apps, e.g. BankingVEU: + + https://play.google.com/store/apps/details?id=subsembly.bankingveu + https://apps.apple.com/de/app/bankingveu/id1578694190 + + Known Issues / Roadmap ====================== - Add support to import externally generated keys & certificates (currently only 3SKey signature certificate). -- Electronic Distributed Signature (EDS) is not supported in the current version of this module. +- Add support for SWIFT 3SKey signing javascript lib (SConnect, cf https://www2.swift.com/3skey/help/sconnect.html). diff --git a/account_ebics/models/ebics_userid.py b/account_ebics/models/ebics_userid.py index 62e9a0d..79ff9f1 100644 --- a/account_ebics/models/ebics_userid.py +++ b/account_ebics/models/ebics_userid.py @@ -72,7 +72,7 @@ class EbicsUserID(models.Model): help="Users who are allowed to use this EBICS UserID for " " bank transactions.", ) - # Currently only a singe signature class per user is supported + # Currently only a single signature class per user is supported # Classes A and B are not yet supported. signature_class = fields.Selection( selection=[("E", "Single signature"), ("T", "Transport signature")], diff --git a/account_ebics/static/description/index.html b/account_ebics/static/description/index.html index dc19440..61ac626 100644 --- a/account_ebics/static/description/index.html +++ b/account_ebics/static/description/index.html @@ -538,12 +538,19 @@ You can also find this information in the doc folder of this module (file EBICS_

+
+

Electronic Distributed Signature (EDS)

+

This is supported via external signing apps, e.g. BankingVEU:

+
+https://play.google.com/store/apps/details?id=subsembly.bankingveu +https://apps.apple.com/de/app/bankingveu/id1578694190
+

Known Issues / Roadmap

  • Add support to import externally generated keys & certificates (currently only 3SKey signature certificate).
    • -
  • Electronic Distributed Signature (EDS) is not supported in the current version of this module.
    • +
  • Add support for SWIFT 3SKey signing javascript lib (SConnect, cf https://www2.swift.com/3skey/help/sconnect.html).
diff --git a/account_ebics/wizards/ebics_xfer.py b/account_ebics/wizards/ebics_xfer.py index 1aa89f7..b2ee29e 100644 --- a/account_ebics/wizards/ebics_xfer.py +++ b/account_ebics/wizards/ebics_xfer.py @@ -463,7 +463,7 @@ class EbicsXfer(models.TransientModel): "passphrase": passphrase, } if self.ebics_sig_passphrase: - keyring_params["sig_passphrase"] = self.ebics_sig_passphrase + keyring_params["sig_passphrase"] = self.ebics_sig_passphrase try: keyring = EbicsKeyRing(**keyring_params) except (RuntimeError, ValueError) as err: