[IMP] small improvements

account_ebics/wizards/ebics_xfer.xml

@@ -99,7 +99,10 @@
                         readonly="context.get('active_model') == 'account.payment.order'"
                     />
                     <field name="order_type" />
-          <field name="test_mode" invisible="order_type not in ('FUL', 'BTU')" />
+                    <field
+                        name="test_mode"
+                        invisible="order_type not in ('FUL', 'BTU')"
+                    />
                     <field name="allowed_format_ids" invisible="1" />
                 </group>
                 <footer>
@@ -176,9 +179,11 @@
         <field name="arch" type="xml">
             <form string="EBICS Mark as Downloaded">
                 <div class="alert alert-warning" role="alert">
-                    The EBICS Files (Bank Statements) selected via this screen will not become available in Odoo as EBICS files but will be marked by your bank as downloaded.
+                    The EBICS Files (Bank Statements) selected via this screen will not become available in Odoo as
+                    EBICS files but will be marked by your bank as downloaded.
                     <br />
-                    As a consequence, these Bank Statements will not be retrieved by the next 'EBICS Batch Import' scheduled action.
+                    As a consequence, these Bank Statements will not be retrieved by the next 'EBICS Batch Import'
+                    scheduled action.
                 </div>
                 <group>
                     <separator string="Select your bank :" colspan="2" />
@@ -199,6 +204,7 @@
                         invisible="ebics_passphrase_store"
                         required="not ebics_passphrase_store"
                     />
+                    <field name="ebics_passphrase_store" invisible="1" />
                     <field name="date_from" required="1" />
                     <field name="date_to" required="1" />
                     <field
@@ -206,6 +212,7 @@
                         required="1"
                         domain="[('type', '=', 'down'), ('id', 'in', allowed_format_ids)]"
                     />
+                    <field name="allowed_format_ids" invisible="1" />
                 </group>
                 <footer>
                     <button

account_ebics_batch_payment/models/account_batch_payment.py

@@ -1,15 +1,18 @@
 # Copyright 2020 Noviat.
 # License LGPL-3 or later (http://www.gnu.org/licenses/lgpl).
 
-from odoo import _, fields, models
+from odoo import _, api, fields, models
 from odoo.exceptions import UserError
 
 
 class AccountBatchPayment(models.Model):
     _inherit = "account.batch.payment"
 
-    hide_ebics_upload = fields.Boolean(compute="_compute_hide_ebics_upload")
+    hide_ebics_upload = fields.Boolean(
+        compute="_compute_hide_ebics_upload", default=True
+    )
 
+    @api.depends("journal_id.ebics_config_id", "file_generation_enabled", "state")
     def _compute_hide_ebics_upload(self):
         for rec in self:
             rec.hide_ebics_upload = (
@@ -47,7 +50,6 @@ class AccountBatchPayment(models.Model):
         view = self.env.ref("account_ebics.ebics_xfer_view_form_upload")
         act = {
             "name": _("EBICS Upload"),
-            "view_type": "form",
             "view_mode": "form",
             "res_model": "ebics.xfer",
             "view_id": view.id,

account_ebics_payment_order/models/account_payment_mode.py

@@ -1,5 +1,5 @@
 # Copyright 2015 Noviat.
-# License LGPL-3 or later (https://www.gnu.org/licenses/lpgl).
+# License LGPL-3 or later (https://www.gnu.org/licenses/lgpl).
 
 from odoo import fields, models
 

account_ebics_payment_order/models/account_payment_order.py

@@ -1,15 +1,18 @@
 # Copyright 2015 Noviat.
 # License LGPL-3 or later (https://www.gnu.org/licenses/lgpl).
 
-from odoo import _, fields, models
+from odoo import _, api, fields, models
 from odoo.exceptions import UserError
 
 
 class AccountPaymentOrder(models.Model):
     _inherit = "account.payment.order"
 
-    hide_ebics_upload = fields.Boolean(compute="_compute_hide_ebics_upload")
+    hide_ebics_upload = fields.Boolean(
+        compute="_compute_hide_ebics_upload", default=True
+    )
 
+    @api.depends("journal_id.ebics_config_id", "state")
     def _compute_hide_ebics_upload(self):
         for rec in self:
             rec.hide_ebics_upload = (
@@ -77,7 +80,6 @@ class AccountPaymentOrder(models.Model):
             view = self.env.ref("account_ebics.ebics_xfer_view_form_upload")
             act = {
                 "name": _("EBICS Upload"),
-                "view_type": "form",
                 "view_mode": "form",
                 "res_model": "ebics.xfer",
                 "view_id": view.id,