From cbb1f8a24878753ecd4949ca38338fcf7b5abe65 Mon Sep 17 00:00:00 2001
From: Luc De Meyer <luc.demeyer@noviat.com>
Date: Wed, 2 Dec 2020 21:35:06 +0100
Subject: [PATCH] update for subscription based fintech licensing

---
 account_ebics/README.rst                       |  2 ++
 account_ebics/__manifest__.py                  |  2 +-
 account_ebics/models/fintech_ebics_register.py | 11 +++++++----
 account_ebics/static/description/index.html    |  4 +++-
 4 files changed, 13 insertions(+), 6 deletions(-)

diff --git a/account_ebics/README.rst b/account_ebics/README.rst
index 54aeab8..37065ed 100644
--- a/account_ebics/README.rst
+++ b/account_ebics/README.rst
@@ -87,6 +87,8 @@ The keycode of the licensed version.
 - fintech_register_users
 
 The licensed EBICS user ids. It must be a string or a list of user ids.
+You should NOT specify this parameter is your license is subsciption
+based (with monthly recurring billing).
 
 |
 | Example:
diff --git a/account_ebics/__manifest__.py b/account_ebics/__manifest__.py
index fd3324d..004b2cb 100644
--- a/account_ebics/__manifest__.py
+++ b/account_ebics/__manifest__.py
@@ -3,7 +3,7 @@
 
 {
     'name': 'EBICS banking protocol',
-    'version': '13.0.1.2.0',
+    'version': '13.0.1.2.1',
     'license': 'LGPL-3',
     'author': 'Noviat',
     'website': 'www.noviat.com',
diff --git a/account_ebics/models/fintech_ebics_register.py b/account_ebics/models/fintech_ebics_register.py
index d42a207..5a97aaa 100644
--- a/account_ebics/models/fintech_ebics_register.py
+++ b/account_ebics/models/fintech_ebics_register.py
@@ -21,13 +21,16 @@ fintech_register_users = config.get('fintech_register_users')
 
 try:
     if fintech:
-        fintech_register_users = fintech_register_users \
+        fintech_register_users = (
+            fintech_register_users
             and [x.strip() for x in fintech_register_users.split(',')]
+            or None
+        )
         fintech.cryptolib = 'cryptography'
         fintech.register(
-            fintech_register_name,
-            fintech_register_keycode,
-            fintech_register_users)
+            name=fintech_register_name,
+            keycode=fintech_register_keycode,
+            users=fintech_register_users)
 except RuntimeError as e:
     if e.message == "'register' can be called only once":
         pass
diff --git a/account_ebics/static/description/index.html b/account_ebics/static/description/index.html
index 570ff71..1c8b5ca 100644
--- a/account_ebics/static/description/index.html
+++ b/account_ebics/static/description/index.html
@@ -423,7 +423,9 @@ licensing parameters to the odoo server configuration file:</p>
 <ul class="simple">
 <li>fintech_register_users</li>
 </ul>
-<p>The licensed EBICS user ids. It must be a string or a list of user ids.</p>
+<p>The licensed EBICS user ids. It must be a string or a list of user ids.
+You should NOT specify this parameter is your license is subsciption
+based (with monthly recurring billing).</p>
 <div class="line-block">
 <div class="line"><br /></div>
 <div class="line">Example:</div>