From ebe6a6b43d94d6f724a5afbf9e308bc3ad997467 Mon Sep 17 00:00:00 2001
From: Luc De Meyer <luc.demeyer@noviat.com>
Date: Fri, 3 Jan 2025 15:01:54 +0100
Subject: [PATCH] [IMP] account_ebics: hide process button on ebics_file when
 no download process

---
 account_ebics/__manifest__.py                 |   4 +-
 .../migrations/17.0.1.2/post-migration.py     |  15 +++
 account_ebics/models/ebics_file.py            |   7 +-
 account_ebics/views/ebics_config_views.xml    |   2 +-
 .../views/ebics_file_format_views.xml         | 104 +++++++++---------
 account_ebics/views/ebics_file_views.xml      |  47 +++++---
 account_ebics/views/ebics_userid_views.xml    |   2 +-
 account_ebics/views/menu.xml                  |   2 +-
 account_ebics/wizards/ebics_xfer.py           |   3 +-
 account_ebics_batch/__manifest__.py           |   4 +-
 account_ebics_batch/models/ebics_batch_log.py |   4 +-
 11 files changed, 113 insertions(+), 81 deletions(-)
 create mode 100644 account_ebics/migrations/17.0.1.2/post-migration.py

diff --git a/account_ebics/__manifest__.py b/account_ebics/__manifest__.py
index 5b9b51a..df81bb9 100644
--- a/account_ebics/__manifest__.py
+++ b/account_ebics/__manifest__.py
@@ -1,9 +1,9 @@
-# Copyright 2009-2024 Noviat.
+# Copyright 2009-2025 Noviat.
 # License LGPL-3 or later (http://www.gnu.org/licenses/lgpl).
 
 {
     "name": "EBICS banking protocol",
-    "version": "17.0.1.1.2",
+    "version": "17.0.1.2.0",
     "license": "LGPL-3",
     "author": "Noviat",
     "website": "https://www.noviat.com",
diff --git a/account_ebics/migrations/17.0.1.2/post-migration.py b/account_ebics/migrations/17.0.1.2/post-migration.py
new file mode 100644
index 0000000..2c5b89e
--- /dev/null
+++ b/account_ebics/migrations/17.0.1.2/post-migration.py
@@ -0,0 +1,15 @@
+# Copyright 2009-2025 Noviat.
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+
+def migrate(cr, version):
+    cr.execute(  # pylint: disable=E8103
+        """
+    UPDATE ebics_file ef
+    SET state = 'done'
+    FROM ebics_file_format eff
+    WHERE ef.format_id = eff.id
+          AND eff.type = 'down'
+          AND eff.download_process_method IS NULL;
+        """
+    )
diff --git a/account_ebics/models/ebics_file.py b/account_ebics/models/ebics_file.py
index 66f2af8..6eb0157 100644
--- a/account_ebics/models/ebics_file.py
+++ b/account_ebics/models/ebics_file.py
@@ -1,4 +1,4 @@
-# Copyright 2009-2024 Noviat.
+# Copyright 2009-2025 Noviat.
 # License LGPL-3 or later (http://www.gnu.org/licenses/lgpl).
 
 import base64
@@ -36,7 +36,10 @@ class EbicsFile(models.Model):
     format_id = fields.Many2one(
         comodel_name="ebics.file.format", string="EBICS File Formats", readonly=True
     )
-    type = fields.Selection(related="format_id.type", readonly=True)
+    download_process_method = fields.Selection(
+        related="format_id.download_process_method"
+    )
+    type = fields.Selection(related="format_id.type")
     date_from = fields.Date(
         readonly=True, help="'Date From' as entered in the download wizard."
     )
diff --git a/account_ebics/views/ebics_config_views.xml b/account_ebics/views/ebics_config_views.xml
index 054586b..750d4db 100644
--- a/account_ebics/views/ebics_config_views.xml
+++ b/account_ebics/views/ebics_config_views.xml
@@ -1,4 +1,4 @@
-<?xml version="1.0" ?>
+<?xml version="1.0" encoding="utf-8" ?>
 <odoo>
 
   <record id="ebics_config_view_tree" model="ir.ui.view">
diff --git a/account_ebics/views/ebics_file_format_views.xml b/account_ebics/views/ebics_file_format_views.xml
index 25b81e7..8047b5c 100644
--- a/account_ebics/views/ebics_file_format_views.xml
+++ b/account_ebics/views/ebics_file_format_views.xml
@@ -1,74 +1,74 @@
-<?xml version="1.0" ?>
+<?xml version="1.0" encoding="utf-8" ?>
 <odoo>
 
-  <record id="ebics_file_format_view_tree" model="ir.ui.view">
-    <field name="name">ebics.file.format.tree</field>
-    <field name="model">ebics.file.format</field>
-    <field name="arch" type="xml">
-      <tree>
-                  <field name="ebics_version" />
-        <field name="type" />
-        <field name="order_type" />
-        <field name="signature_class" />
-        <field name="name" />
-        <field name="description" />
-      </tree>
-    </field>
-  </record>
+    <record id="ebics_file_format_view_tree" model="ir.ui.view">
+        <field name="name">ebics.file.format.tree</field>
+        <field name="model">ebics.file.format</field>
+        <field name="arch" type="xml">
+            <tree>
+                <field name="ebics_version" />
+                <field name="type" />
+                <field name="order_type" />
+                <field name="signature_class" />
+                <field name="name" />
+                <field name="description" />
+            </tree>
+        </field>
+    </record>
 
-  <record id="ebics_file_format_view_form" model="ir.ui.view">
-    <field name="name">ebics.file.format.form</field>
-    <field name="model">ebics.file.format</field>
-    <field name="arch" type="xml">
-      <form string="EBICS File Format">
-        <group name="main">
-          <group name="main-left">
-            <field name="ebics_version" />
-            <field name="type" />
-            <field name="suffix" />
-            <field
+    <record id="ebics_file_format_view_form" model="ir.ui.view">
+        <field name="name">ebics.file.format.form</field>
+        <field name="model">ebics.file.format</field>
+        <field name="arch" type="xml">
+            <form string="EBICS File Format">
+                <group name="main">
+                    <group name="main-left">
+                        <field name="ebics_version" />
+                        <field name="type" />
+                        <field name="suffix" />
+                        <field
                             name="download_process_method"
                             invisible="type == 'up'"
                             force_save="1"
                         />
-            <field name="signature_class" />
-          </group>
-          <group name="main-right">
-            <field name="order_type" />
-            <field
+                        <field name="signature_class" />
+                    </group>
+                    <group name="main-right">
+                        <field name="order_type" />
+                        <field
                             name="name"
                             required="ebics_version == '2'"
                             invisible="ebics_version == '3'"
                         />
-            <field
+                        <field
                             name="btf_service"
                             required="ebics_version == '3'"
                             invisible="ebics_version == '2'"
                         />
-            <field
+                        <field
                             name="btf_message"
                             required="ebics_version == '3'"
                             invisible="ebics_version == '2'"
                         />
-            <field name="btf_scope" invisible="ebics_version == '2'" />
-            <field name="btf_option" invisible="ebics_version == '2'" />
-            <field name="btf_container" invisible="ebics_version == '2'" />
-            <field name="btf_version" invisible="ebics_version == '2'" />
-            <field name="btf_variant" invisible="ebics_version == '2'" />
-            <field name="btf_format" invisible="ebics_version == '2'" />
-          </group>
-        </group>
-        <group name="description">
-          <field name="description" />
-        </group>
-      </form>
-    </field>
-  </record>
+                        <field name="btf_scope" invisible="ebics_version == '2'" />
+                        <field name="btf_option" invisible="ebics_version == '2'" />
+                        <field name="btf_container" invisible="ebics_version == '2'" />
+                        <field name="btf_version" invisible="ebics_version == '2'" />
+                        <field name="btf_variant" invisible="ebics_version == '2'" />
+                        <field name="btf_format" invisible="ebics_version == '2'" />
+                    </group>
+                </group>
+                <group name="description">
+                    <field name="description" />
+                </group>
+            </form>
+        </field>
+    </record>
 
-  <record id="ebics_file_format_action" model="ir.actions.act_window">
-    <field name="name">EBICS File Formats</field>
-    <field name="res_model">ebics.file.format</field>
-    <field name="view_mode">tree,form</field>
-  </record>
+    <record id="ebics_file_format_action" model="ir.actions.act_window">
+        <field name="name">EBICS File Formats</field>
+        <field name="res_model">ebics.file.format</field>
+        <field name="view_mode">tree,form</field>
+    </record>
 
 </odoo>
diff --git a/account_ebics/views/ebics_file_views.xml b/account_ebics/views/ebics_file_views.xml
index 9d4771a..6ffbfd3 100644
--- a/account_ebics/views/ebics_file_views.xml
+++ b/account_ebics/views/ebics_file_views.xml
@@ -1,4 +1,4 @@
-<?xml version="1.0" ?>
+<?xml version="1.0" encoding="utf-8" ?>
 <odoo>
 
     <record id="ebics_file_view_search" model="ir.ui.view">
@@ -77,9 +77,10 @@
         <field name="arch" type="xml">
             <form string="EBICS File" create="false">
                 <header>
+                    <field name="download_process_method" invisible="1" />
                     <button
                         name="set_to_draft"
-                        invisible="state != 'done'"
+                        invisible="not download_process_method or state != 'done'"
                         string="Set to Draft"
                         type="object"
                         groups="account.group_account_manager"
@@ -87,7 +88,7 @@
                     <button
                         name="process"
                         class="oe_highlight"
-                        invisible="state != 'draft'"
+                        invisible="not download_process_method or state != 'draft'"
                         string="Process"
                         type="object"
                         groups="account.group_account_invoice"
@@ -95,27 +96,37 @@
                     />
                     <button
                         name="set_to_done"
-                        invisible="state != 'draft'"
+                        invisible="not download_process_method or state != 'draft'"
                         string="Set to Done"
                         type="object"
                         groups="account.group_account_manager"
                     />
-                    <field name="state" widget="statusbar" />
-                </header>
-                <group colspan="4" col="4">
-                    <field name="date" string="Download Date" />
-                    <field name="name" />
-                    <field name="data" filename="name" />
-                    <field name="format_id" />
-                    <field name="date_from" />
-                    <field name="date_to" />
-                    <field name="user_id" />
-                    <field name="ebics_userid_id" />
                     <field
-                        name="company_ids"
-                        widget="many2many_tags"
-                        groups="base.group_multi_company"
+                        name="state"
+                        widget="statusbar"
+                        invisible="not download_process_method"
                     />
+                </header>
+                <group name="main">
+                    <group name="main-full-screen" colspan="2" col="2">
+                        <field name="name" />
+                        <field name="data" filename="name" />
+                        <field name="format_id" />
+                    </group>
+                    <group name="main-left">
+                        <field name="date" string="Download Date" />
+                        <field name="user_id" />
+                        <field name="ebics_userid_id" />
+                    </group>
+                    <group name="main-right">
+                        <field name="date_from" />
+                        <field name="date_to" />
+                        <field
+                            name="company_ids"
+                            widget="many2many_tags"
+                            groups="base.group_multi_company"
+                        />
+                    </group>
                 </group>
                 <notebook>
                     <page string="Additional Information">
diff --git a/account_ebics/views/ebics_userid_views.xml b/account_ebics/views/ebics_userid_views.xml
index 61447be..92f4569 100644
--- a/account_ebics/views/ebics_userid_views.xml
+++ b/account_ebics/views/ebics_userid_views.xml
@@ -1,4 +1,4 @@
-<?xml version="1.0" ?>
+<?xml version="1.0" encoding="utf-8" ?>
 <odoo>
 
   <record id="ebics_userid_view_tree" model="ir.ui.view">
diff --git a/account_ebics/views/menu.xml b/account_ebics/views/menu.xml
index 1ad1b0c..0ac9cee 100644
--- a/account_ebics/views/menu.xml
+++ b/account_ebics/views/menu.xml
@@ -1,4 +1,4 @@
-<?xml version="1.0" ?>
+<?xml version="1.0" encoding="utf-8" ?>
 <odoo>
 
   <menuitem
diff --git a/account_ebics/wizards/ebics_xfer.py b/account_ebics/wizards/ebics_xfer.py
index 1b9925d..2034ca8 100644
--- a/account_ebics/wizards/ebics_xfer.py
+++ b/account_ebics/wizards/ebics_xfer.py
@@ -1,4 +1,4 @@
-# Copyright 2009-2024 Noviat.
+# Copyright 2009-2025 Noviat.
 # License LGPL-3 or later (http://www.gnu.org/licenses/lgpl).
 
 import base64
@@ -605,6 +605,7 @@ class EbicsXfer(models.TransientModel):
             "date_from": self.date_from,
             "date_to": self.date_to,
             "format_id": file_format.id,
+            "state": file_format.download_process_method and "draft" or "done",
             "user_id": self._uid,
             "ebics_userid_id": self.ebics_userid_id.id,
             "company_ids": self.ebics_config_id.company_ids.ids,
diff --git a/account_ebics_batch/__manifest__.py b/account_ebics_batch/__manifest__.py
index 77d566e..e975a3d 100644
--- a/account_ebics_batch/__manifest__.py
+++ b/account_ebics_batch/__manifest__.py
@@ -1,9 +1,9 @@
-# Copyright 2009-2024 Noviat.
+# Copyright 2009-2025 Noviat.
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
 {
     "name": "EBICS Files batch import",
-    "version": "17.0.1.0.0",
+    "version": "17.0.1.0.1",
     "license": "AGPL-3",
     "author": "Noviat",
     "website": "https://www.noviat.com",
diff --git a/account_ebics_batch/models/ebics_batch_log.py b/account_ebics_batch/models/ebics_batch_log.py
index bc2b025..c910739 100644
--- a/account_ebics_batch/models/ebics_batch_log.py
+++ b/account_ebics_batch/models/ebics_batch_log.py
@@ -179,7 +179,9 @@ class EbicsBatchLog(models.Model):
         return file_ids
 
     def _ebics_process(self, import_dict):
-        to_process = self.file_ids.filtered(lambda r: r.state == "draft")
+        to_process = self.file_ids.filtered(
+            lambda r: r.download_process_method and r.state == "draft"
+        )
         for ebics_file in to_process:
             ebics_file.process()